Adds name to the error for group data call #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
If necessary, I'm willing to wait for #155 to be merged in and I'll rework these logging changes based upon those changes. I think that should take priority over this in terms of merge ordering. |
|
@bogdanprodan-okta @noinarisak Would you be able to include this in the next patch release? |
|
@bogdanprodan-okta much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is embedded inside of modules, the error message becomes very difficult to use since the actual call is abstracted. By adding the name of the group to the error message, it makes it much easier to discover which you're not referencing correctly.